Skip to content

Handle page crash when rendering NFTs with unexpected title, description values #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

Handle page crash when rendering NFTs with unexpected title, description values #5095

merged 1 commit into from
Oct 21, 2024
+193 −38

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 21, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces the react-error-boundary package and enhances error handling in the NFT-related components by implementing UnexpectedValueErrorMessage. It improves user feedback for invalid data in the TokenIdPage and NFTGetAllTable.

Detailed summary

  • Added react-error-boundary to handle errors gracefully.
  • Created UnexpectedValueErrorMessage component for displaying error messages.
  • Implemented error handling for NFT names and descriptions in TokenIdPage.
  • Updated NFTGetAllTable to use UnexpectedValueErrorMessage for invalid NFT data.
  • Wrapped NFT cell rendering in ErrorBoundary for better error management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 4:52pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 4:52pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 4:52pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 4:52pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1a45f21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 21, 2024 16:16
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 21, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@socket-security
Copy link

socket-security bot commented Oct 21, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-error-boundary@4.1.2 None +2 309 kB brianvaughn

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 348 ms (-9.28% 🔽) 1.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 1.2 s (-7.09% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 222 ms (+688.87% 🔺) 319 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 73 ms (+349.49% 🔺) 83 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 374 ms (+269.97% 🔺) 721 ms

@MananTank MananTank changed the title Handle page crash when rendering NFTs with unexpected title, description Handle page crash when rendering NFTs with unexpected title, description values Oct 21, 2024
@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (d59ab13) to head (1a45f21).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5095   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3957     3959    +2     
=======================================
  Hits        24804    24804           
  Misses      29259    29259           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d59ab13
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024 •
edited by MananTank
Loading

Merge activity

@MananTank
Handle page crash when rendering NFTs with unexpected title, descript…
1a45f21 
…ion values (#5095)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces error handling components to display messages for unexpected values in the NFT-related pages, enhancing user experience by providing feedback when data does not meet expectations.

### Detailed summary
- Added `react-error-boundary` to handle errors.
- Created `UnexpectedValueErrorMessage` component for displaying error messages.
- Integrated error handling in `TokenIdPage`, `NFTName`, and `NFTDescription` components.
- Updated `NFTGetAllTable` to use `UnexpectedValueErrorMessage` for invalid data.
- Wrapped NFT cell rendering in `ErrorBoundary` to catch errors.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-21-handle_page_crash_when_rendering_nfts_with_unexpected_title_description branch from 09d0b86 to 1a45f21 Compare October 21, 2024 16:42
@graphite-app graphite-app bot merged commit 1a45f21 into main Oct 21, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-21-handle_page_crash_when_rendering_nfts_with_unexpected_title_description branch October 21, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls